Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/320#discussion_r43908535
--- Diff: proxy/logging/Log.cc ---
@@ -1242,7 +1242,15 @@ Log::flush_thread_main(void * /* args ATS_UNUSED */)
break;
}
+ int logfilefd = logfile->get_fd();
--- End diff --
I tweaked this to be moved out of the loop. If it's OK when the loop starts
it will be OK every loop iteration. And in that case, we might as well depend
on `check_fd` to have verified that and just use an `ink_assert` to make
Coverity happy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
