Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/259#discussion_r35712793
--- Diff: mgmt/Alarms.cc ---
@@ -413,6 +413,7 @@ Alarms::constructAlarmMessage(const AppVersionInfo
&version, char *ip, char *mes
if (max >= 1) {
message[0] = '\0';
}
+ ink_mutex_release(&mutex);
--- End diff --
I think this would be better done with SCOPED_MUTEX_LOCK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
