Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r33196590
--- Diff: proxy/http/HttpSM.cc ---
@@ -4622,16 +4623,16 @@ HttpSM::do_http_server_open(bool raw)
ink_assert(pending_action == NULL);
if (false == t_state.api_server_addr_set) {
- ink_assert(t_state.current.server->port > 0);
- t_state.current.server->addr.port() =
htons(t_state.current.server->port);
+ ink_assert(t_state.current.server->dst_addr.port() > 0);
+ t_state.current.server->dst_addr.port() =
htons(t_state.current.server->dst_addr.port());
--- End diff --
This will flip the byte order which seems like a bad idea. In the previous
state the separate port was stored in host order and this was needed to flip it
to network order to be used in the `IpEndpoint`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
