James, thanks for the comments. I had some old references and as you noted did not discuss how memory is tracked through the API's.

I've updated the document http://network-geographics.com/ats/docs/ssl-session-api.en.html

On my branch, I have a very simple example plugin which exercises the new hook

https://github.com/shinrich/trafficserver/blob/TS-3527/example/ssl-session/ssl-session.cc

I've also created a pull request on my working branch.

https://github.com/apache/trafficserver/pull/217https://github.com/apache/trafficserver/pull/217


On 6/10/2015 6:11 PM, James Peach wrote:
On Jun 10, 2015, at 3:24 PM, Susan Hinrichs <shinr...@network-geographics.com> 
wrote:

I haven't heard anything about this.  We did discuss it at the Austin Summit.  
There was general agreement to the idea.  I've updated the document to reflect 
what I have implemented.  I will create a pull request with the code changes 
later this evening.

The details of the API are at
http://network-geographics.com/ats/docs/ssl-session-api.en.html

Please share your comments and  concerns.
How do you register this hook? What is TSSslSessionCurrentInsert()?

Many of the naming is inconsistent. For example, TSSslSessionId_t. We "Id" should be 
spelled "ID", etc.

This API needs to talk about the lifecycle of the session and what locking is 
involved. Who owns the object returned by TSSslSessionGet()? Does 
TSSslSessionInsert() replace an existing entry?

On 3/18/2015 10:52 AM, Susan Hinrichs wrote:
The motivation is to leverage the core SSL session support of ATS while 
enabling others to add things like multi-ATS session state sharing, additional 
stats, additional checks, etc.

Proposed interface write up here
http://network-geographics.com/ats/docs/ssl-session-api.en.html

Please give me your comments.

Thanks,
Susan




Reply via email to