Github user zwoop commented on the pull request:

    https://github.com/apache/trafficserver/pull/184#issuecomment-97145130
  
    Couple of things:
    
    1) Please always file a Jira before making a github pull commit for code 
changes (not docs). Also include that Jira in the commit message.
    
    2) Please use our indentation style as dictated by the clang-format setup. 
See mailing list for more details.
    
    3) I still don't see how this can cause any serious memory leaks. If it 
does, we really have a very very fundamental problem, the only way I can 
imagine this leaking noticeable memory is either if we somehow duplicate the 
configuration object accidentally, or if you truly reload your configs every 5s 
or some such (which would be bad on its own).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to