Thanks, Bryan!
One (minor) note - on further thought, it seems to me that for the server 
socket,  it should not be possible to have a Ssn without a Txn. So, I would 
simply add just the TSHttpTxnServerFdGet API and *not* add the 
TSHttpSsnServerFdGet.
Please let me know if anyone has comments/concerns.
Regards,
Sudheer  


     On Thursday, April 9, 2015 9:58 AM, Bryan Call <bc...@apache.org> wrote:
   

 +1 - Looks good.

-Bryan




> On Apr 7, 2015, at 10:38 AM, Sudheer Vinukonda 
> <sudhe...@yahoo-inc.com.INVALID> wrote:
> 
> Currently, there's TS API to get the client socket's fd TSHttpTxnClientFdGet 
> / TSHttpSsnClientFdGet. This API is used by the tcpinfo plugin to get tcp 
> stats for the client side socket.
> I'd like to add corresponding TS API to get origin server socket's fd as 
> below. 
> TSReturnCode TSHttpTxnServerFdGet(TSHttpTxn txnp, int *fdp);
> TSReturnCode TSHttpSsnServerFdGet(TSHttpSsn ssnp, int *fdp); The use case is 
> to allow retrieving origin side connection's tcp stats (for e.g. extend 
> tcpinfo or as part of a different plugin).
> I've opened TS-3502 (https://issues.apache.org/jira/browse/TS-3502) for this 
> change.
> Please review and provide comments/concerns.
> Thanks,
> Sudheer


  

Reply via email to