On Tue Jan 27 2015 at 10:09:14 AM James Peach <jpe...@apache.org> wrote:
> > > On Jan 26, 2015, at 3:19 PM, Phil Sorber <sor...@apache.org> wrote: > > > > I am proposing we deprecate the following: > > > > tsapi TSReturnCode TSHttpTxnClientPacketTosSet(TSHttpTxn txnp, int tos); > > tsapi TSReturnCode TSHttpTxnServerPacketTosSet(TSHttpTxn txnp, int tos); > > > > And replace them with: > > > > tsapi TSReturnCode TSHttpTxnClientPacketDscpSet(TSHttpTxn txnp, int > dscp); > > tsapi TSReturnCode TSHttpTxnServerPacketDscpSet(TSHttpTxn txnp, int > dscp); > > > > The new versions can be added immediately. And the old versions can be > > remove in the future. Either 6.0 or 7.0. > > This sounds reasonable to me. > > > The reasoning for this is that the TOS field in the TCP header has been > > deprecated and is now the DSCP and ECN field. The comments in our API > even > > explain this. > > > > The main functional difference is that we shift the DSCP over by 2. > > What about proxy.config.net.sock_packet_tos_in, > proxy.config.net.sock_packet_tos_out and proxy.config.cluster.sock_ > packet_tos? > > After more thought on the subject, maybe I'll leave everything TOS and just add DSCP as a convenience wrapper. It looks like the only way to set the DSCP field is through a TOS call anyway. So even though it's deprecated in the IP packet layer, the API's seem to be remaining the same. This means I would leave all the configs as-is as well. Maybe additional ones. Thoughts on that? J > >
