> On Nov 17, 2014, at 4:09 PM, Sudheer Vinukonda > <sudhe...@yahoo-inc.com.INVALID> wrote: > > Hi All, > > I would like add a new API TSSslAdvertiseProtocolSet(), to address the > requirement of modifying the NPN advertising list for each SSL connection > based on SNI (please refer TS-3153). > > https://issues.apache.org/jira/browse/TS-3153 > > > Below is a brief description of the API. Please review and provide > comments/concerns. > > > > +TSSslAdvertiseProtocolSet > +============ > + > +Synopsis > +-------- > + > +`#include <ts/ts.h>` > + > +.. c:function:: TSReturnCode TSSslAdvertiseProtocolSet(TSVConn sslp, > const unsigned char ** list, unsigned int count);
In the rest of the APIs, we use the term "named protocol". This API does not let you set arbitrary protocol names, so I'd suggest TSReturnCode TSSslFilterNamedProtocols() > + > +Description > +----------- > + > + Modifies the NPN advertisement list for a given SSL connection with > :arg:`list`. What is list? In what way is the advertisement list modified? > If :arg:`count` is 0, sets the NPN advertisement list to the > default registered protocol list for the end point. Isn't the default already the default? If list is NULL or count is 0, just return an error. > Note that, the plugin > that uses this API owns the :arg:`list` and is responsible for making sure > it points to a valid memory. Not sure what you are saying here? I guess we should never pass invalid memory anywhere, right? > + > > > > Thanks, > > Sudheer >
