On May 26, 2014, at 5:56 PM, Leif Hedstrom <zw...@apache.org> wrote: > > >> On May 26, 2014, at 6:41 PM, James Peach <jpe...@apache.org> wrote: >> >>> On May 23, 2014, at 5:47 PM, zw...@apache.org wrote: >>> >>> Repository: trafficserver >>> Updated Branches: >>> refs/heads/master 639329e38 -> bc054cf8d >>> >>> >>> TS-2528 Use <stdbool.h> in the public mgmtapi.h interface, C99 standard. >> >> So we now require C99 to build plugins? That sounds reasonable, but it >> should be > > No. We have no mgmt plugins / code, other than traffic_line. In fact, I don't > think it's documented at all ? I'll have a loksie though.
But AFAICT we do ship it as public API. >> documented. Are you planning to change the ts.h APIs as well? > > That was the plan, but I don't know if that will go in for 5.0.0. > > -- Leif >> >>> >>> >>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo >>> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/bc054cf8 >>> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/bc054cf8 >>> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/bc054cf8 >>> >>> Branch: refs/heads/master >>> Commit: bc054cf8d8a7254061411f53b999c8b0cfa1052d >>> Parents: 639329e >>> Author: Leif Hedstrom <zw...@apache.org> >>> Authored: Fri May 23 18:46:13 2014 -0600 >>> Committer: Leif Hedstrom <zw...@apache.org> >>> Committed: Fri May 23 18:46:13 2014 -0600 >>> >>> ---------------------------------------------------------------------- >>> CHANGES | 3 +++ >>> mgmt/api/include/mgmtapi.h | 26 +------------------------- >>> 2 files changed, 4 insertions(+), 25 deletions(-) >>> ---------------------------------------------------------------------- >>> >>> >>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/bc054cf8/CHANGES >>> ---------------------------------------------------------------------- >>> diff --git a/CHANGES b/CHANGES >>> index e50acad..a45df8a 100644 >>> --- a/CHANGES >>> +++ b/CHANGES >>> @@ -1,6 +1,9 @@ >>> -*- coding: utf-8 -*- >>> Changes with Apache Traffic Server 5.0.0 >>> >>> + *) [TS-2528] Use <stdbool.h> in the public mgmtapi.h interface. This >>> follows >>> + the C99 standard, and we should move other public APIs to it. >>> + >>> *) [TS-2428] Move P_Freer.h continuations to run on ET_TASK (if available). >>> >>> *) [TS-2344] 404 error was logged while url redirect request was processed >>> >>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/bc054cf8/mgmt/api/include/mgmtapi.h >>> ---------------------------------------------------------------------- >>> diff --git a/mgmt/api/include/mgmtapi.h b/mgmt/api/include/mgmtapi.h >>> index 19ff2ec..c9fc90d 100644 >>> --- a/mgmt/api/include/mgmtapi.h >>> +++ b/mgmt/api/include/mgmtapi.h >>> @@ -28,6 +28,7 @@ >>> #ifndef __TS_MGMT_API_H__ >>> #define __TS_MGMT_API_H__ >>> >>> +#include <stdbool.h> >>> #include <stdint.h> >>> >>> /*************************************************************************** >>> @@ -35,34 +36,9 @@ >>> ***************************************************************************/ >>> >>> #define tsapi >>> - >>> #define inkexp >>> #define inkimp >>> >>> -#if !defined(linux) >>> -#if defined (__SUNPRO_CC) || (defined (__GNUC__) || ! defined(__cplusplus)) >>> -#if !defined (bool) >>> -#if !defined(darwin) && !defined(freebsd) && !defined(solaris) >>> -/* XXX: What other platforms are there? */ >>> -#define bool int >>> -#endif >>> -#endif >>> - >>> -#if !defined (true) >>> -#define true 1 >>> -#endif >>> - >>> -#if !defined (false) >>> -#define false 0 >>> -#endif >>> - >>> -#endif >>> -#endif /* not linux */ >>> - >>> -#if !defined (NULL) >>> -#define NULL 0 >>> -#endif >>> - >>> #ifdef __cplusplus >>> extern "C" >>> { >>
