On Tue, Apr 15, 2014 at 4:44 PM, Leif Hedstrom <zw...@apache.org> wrote:
> Hi all, > > we added LuaJIT as a submodule, and it seems to be breaking in odd ways on > the build systems. Some of them handles it, others do not. Presumably > different git versions? E.g. it works on CentOS5, but not CentOS6, etc. etc. > > How do we feel about simply just “importing” this into the tree, and deal > with merging in upstream changes as necessary ? Unless someone else has a > solution to this, I think that’s what we’ll have to do. > I know some people have issues with that, and it's not ideal, but I am +1 on it. In my experience, git submodule does not always work as expected. I dunno if it's not heavily used/tested, or flawed design. If we plan to stick with one version anyway, it shouldn't be much of an issue and if someone figures out what we are doing wrong with submodule we can always go back to it in the future. > > Cheers, > > — Leif > >
