Yeah, I just wanted avoid further confusion as what ensued on IRC :) Also, Dynamic as denoted in RecordsConfig means it can be set with traffic line without restarts. So, unless we add another state, or something , it more feels this return value is not useful in this API?
-- Leif > On Mar 16, 2014, at 4:52 PM, James Peach <jpe...@apache.org> wrote: > >> On Mar 16, 2014, at 2:03 PM, zw...@apache.org wrote: >> >> Repository: trafficserver >> Updated Branches: >> refs/heads/master d3fd1e674 -> 4836e4e27 >> >> >> TS-2628 Remove the wrong notification for not, to avoid spreading bad info. > > This seems fine for now, but as we discussed, the right fix is to make sure > the data in RecordsConfig.cc is accurate ... > >> >> >> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo >> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/4836e4e2 >> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/4836e4e2 >> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/4836e4e2 >> >> Branch: refs/heads/master >> Commit: 4836e4e27d9e17fe7f794b2c370c2d51d370a638 >> Parents: d3fd1e6 >> Author: Leif Hedstrom <zw...@apache.org> >> Authored: Sun Mar 16 15:03:17 2014 -0600 >> Committer: Leif Hedstrom <zw...@apache.org> >> Committed: Sun Mar 16 15:03:17 2014 -0600 >> >> ---------------------------------------------------------------------- >> cmd/traffic_line/traffic_line.cc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> ---------------------------------------------------------------------- >> >> >> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/4836e4e2/cmd/traffic_line/traffic_line.cc >> ---------------------------------------------------------------------- >> diff --git a/cmd/traffic_line/traffic_line.cc >> b/cmd/traffic_line/traffic_line.cc >> index 65df8db..738eb13 100644 >> --- a/cmd/traffic_line/traffic_line.cc >> +++ b/cmd/traffic_line/traffic_line.cc >> @@ -267,7 +267,7 @@ handleArgInvocation() >> printf("Set %s, restart required\n", SetVar); >> break; >> case TS_ACTION_RECONFIGURE: >> - printf("Set %s, reconfiguration required\n", SetVar); >> + // printf("Set %s, reconfiguration required\n", SetVar); >> break; >> case TS_ACTION_DYNAMIC: >> default: >
