GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/43
TS-2553 Fix a crash in the Metalink plugin
More work to fix this crash.
I think the existing CHANGES entry for this issue still covers it.
There are also some minor edits and I added some functional tests for
exercising the plugin. (The tests could also potentially exercise other null
transform plugins.)
Let me know if the style or process for contributing changes could be
improved, and feel free to squash any of the changes to clean them up.
Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver TS-2553
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit 21e67b8c574dbeb68533da7fb7e558fa2e156d18
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-05T17:41:55Z
Reorder some functions so related functions are grouped together
commit 8240d6584b016b962bb92a9108a82d38b27330ce
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-05T17:53:02Z
Rename some variables to more easily disambiguate them
commit 07e418dd884a32a9b7313a38664be1161583ed07
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-05T18:07:44Z
Copy the upstream nbytes (if known) downstream to preserve the
"Content-Length: ..." header. In that case there will be a
TS_EVENT_VCONN_WRITE_COMPLETE event from downstream before ntodo is zero, so
write the digest to the cache in transform_vconn_write_complete(). If the
upstream nbytes isn't known until the end of the content, update the downstream
nbytes and reenable it to get it to send a TS_EVENT_VCONN_WRITE_COMPLETE event.
Fix some memory management.
commit 4b2a7ddd8d6603361199daaa0e7f20e7127205ae
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-05T18:16:59Z
Avoid segfault in TSVIOReenable() if the client disconnected
commit 4f736761fa939f9ec376f225e37a81f6cd8b4b0d
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-05T18:18:54Z
Drop TSVIOBufferGet() and test TSVIOReaderGet() instead
commit d43b8018f3d036bcb0f4b7cdb8beaf06e0ae8103
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-05T18:19:52Z
I don't know what this does
commit 85697757ff54f702351b990f84c9669bf19cc5c7
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-05T19:01:40Z
Improve comments
commit 274a45f13d11c52374f692222cdaf8f9aa3635db
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-05T19:06:50Z
Minor edits
commit 943364c2ba60026a7b289091deb5960ef6097580
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-05T20:08:30Z
TS-2553 CHANGES
commit 69d38bcabf56354af2753e5df469648d66034baa
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-19T22:01:47Z
TS-2578 Close the client connection when you close TransformTerminus
commit b08e0b8e68e8d2ee97e3b2eb3395a35acb0e8a87
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-19T22:29:45Z
Merge remote branch 'upstream/master'
Conflicts:
CHANGES
commit 3ff556f2a1c12c3ec85fce76f5071d492be31ef6
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-20T21:00:30Z
metalink: If not at the end yet and can't read any more content then can't
compute the digest
commit 778bbb11309f2008cb338bbd0c19634de66fdae9
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-20T21:06:53Z
metalink: Zero the downstream nbytes is a shortcut to get it to send a
TS_EVENT_VCONN_WRITE_COMPLETE event
commit b5d236989d2997d8a98e39295e176ad62cba12b5
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-20T21:11:30Z
TS-2553 metalink: Avoid failed assert
"sdk_sanity_check_iocore_structure(connp) == TS_SUCCESS" in TSVConnWrite() if
the response is 304 Not Modified
commit f28d2180a5fcee32f11dcc693d085f3f1b1efb1f
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-20T21:13:57Z
metalink: Add some functional tests
commit 888b955720ad977a479d7a2549f3cdc18bcc24c1
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-20T21:22:36Z
metalink: Add Makefile target to run all the tests
commit 2017cc7935c1cd12870e28e50cf35174dd87dec7
Author: Jack Bates <j...@nottheoilrig.com>
Date: 2014-02-20T21:35:25Z
metalink: Declare variables outside switch statement, for consistency
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastruct...@apache.org or file a JIRA ticket with INFRA.
---
