On Jan 16, 2014, at 7:33 PM, Alan M. Carroll <a...@network-geographics.com> 
wrote:

> I am working on command line access to the state of physical storage in the 
> cache. Currently the interface looks like
> 
> traffic_line --device /dev/sdb --cmd offline
> 
> The --device must match a path in storage.config and if so, that physical 
> device is marked offline as if it had failed. I'm in the final stages of 
> cleanup for this feature, so it's time to comment on it if you think it could 
> be better.


I don’t feel particularly strongly about it, but I probably would have 
preferred e.g.

        traffic_line —offline /dev/sdb
        traffic_line —online /dev/sdb


etc. It seems more inline with how things generally works already. I can see 
the original proposal getting confusing if you later add commands which should 
not take a —device option, but something else.  It then gets possible to 
postulate nonsensical combos.

Just my $.01,

— Leif

Reply via email to