On Mon, Jan 6, 2014 at 11:28 AM, James Peach <jpe...@apache.org> wrote:
> On Jan 6, 2014, at 1:06 AM, z...@apache.org wrote: > > > Updated Branches: > > refs/heads/master 024db4624 -> 3344fdfc7 > > > > > > TS-2469: remove libreadline which is gpl licensed > > > > Signed-off-by: Zhao Yongming <ming....@gmail.com> > > > > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > > Commit: > http://git-wip-us.apache.org/repos/asf/trafficserver/commit/3344fdfc > > Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/3344fdfc > > Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/3344fdfc > > > > Branch: refs/heads/master > > Commit: 3344fdfc747470cf4f40ce98afc99191c67565e2 > > Parents: 024db46 > > Author: Ben Aitchison <b...@meh.net.nz> > > Authored: Mon Jan 6 16:39:48 2014 +0800 > > Committer: Zhao Yongming <ming....@gmail.com> > > Committed: Mon Jan 6 16:43:02 2014 +0800 > > > > ---------------------------------------------------------------------- > > CHANGES | 3 +++ > > build/ax_lib_readline.m4 | 2 +- > > 2 files changed, 4 insertions(+), 1 deletion(-) > > ---------------------------------------------------------------------- > > > > > > > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/CHANGES > > ---------------------------------------------------------------------- > > diff --git a/CHANGES b/CHANGES > > index 8a1c2d0..be012eb 100644 > > --- a/CHANGES > > +++ b/CHANGES > > @@ -1,6 +1,9 @@ > > -*- coding: > utf-8 -*- > > Changes with Apache Traffic Server 4.2.0 > > > > + *) [TS-2469] remove libreadline which is gpl licensed. > > + Author: Ben Aitchison <b...@meh.net.nz> > > + > > *) [TS-2235] url_print should NOT output "?" for empty query string, > > fix two remains. > > Author: Yu Qing > > > > > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/build/ax_lib_readline.m4 > > ---------------------------------------------------------------------- > > diff --git a/build/ax_lib_readline.m4 b/build/ax_lib_readline.m4 > > index 37a02a4..1af80b2 100644 > > --- a/build/ax_lib_readline.m4 > > +++ b/build/ax_lib_readline.m4 > > @@ -65,7 +65,7 @@ AC_DEFUN([AX_LIB_READLINE], [ > > AC_CACHE_CHECK([for a readline compatible library], > > ax_cv_lib_readline, [ > > ORIG_LIBS="$LIBS" > > - for readline_lib in readline edit editline; do > > + for readline_lib in edit editline; do > > for termcap_lib in "" termcap curses ncurses; do > > if test -z "$termcap_lib"; then > > TRY_LIB="-l$readline_lib" > > I'm not very comfortable with this change. I don't think it fixes anything > and I don't think that we have a good idea on how this affects > distributions and end users. I'm perfectly happy with preferring libedit to > libreadline, but I'd like some more information about the impact of > removing libreadline. > I agree with this. Preferring libedit seems to meet everyone's goals. We could even take a further step and require a flag to allow it to link against readline. So you effectively get a warning, which you can fix by either installing libedit, or adding a flag to link against readline. That would push people towards libedit about as hard as we could without making our own product useless. > > J >
