On Nov 20, 2013, at 8:25 PM, ASF subversion and git services (JIRA) <j...@apache.org> wrote:
> > [ > https://issues.apache.org/jira/browse/TS-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828454#comment-13828454 > ] > > ASF subversion and git services commented on TS-2374: > ----------------------------------------------------- > > Commit ae51d4ed7b1bf4e162b2c26819b5a88c5cf9ece4 in branch refs/heads/master > from [~taorui] > [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ae51d4e ] > > TS-2374: abort the producer to avoid httpsm hung if none of it`s > consumer is alive.= The comments in the code does not add up to the comments on the Jira above. The code says // abort the producer if the cache_writevc is the only consumer. That seems fundamentally wrong in the case of a background fill, where the only consumer is the cache VC. And read-while-writer depends on this feature as well. If the comments are just odd / wrong, we should change them just for clarity. — leif