On Nov 3, 2013, at 8:40 AM, 永豪 <yong...@taobao.com> wrote: > https://github.com/mingzym/trafficserver/commits/master > > I have a rework in that target, big changes in the last 2 commits, please > help me take a look. > > due to the heavy linking crossing directory, it is ugly and big, but the > basic idea is to split all the libs in it’s own directory and using .la .a > file for cross linking.
Thanks for looking at this. I'll review tomorrow and maybe we can chat on IRC. Any forward progress on the cross-linking is an additional benefit :) > > > tested on gentoo automake-1.14 gcc-4.8.1 and RHEL 6.2 gcc-4.4 automake-1.11 > > > TODO: may need to check the standalone lib > > 在 2013年10月25日，下午11:17，James Peach <jamespe...@me.com> 写道： > >> >> On Oct 24, 2013, at 10:31 PM, Yunkai Zhang <yunkai...@gmail.com> wrote: >> >>> Please read this issue: >>> https://issues.apache.org/jira/browse/TS-2172 >>> >>> It's a duplicated work, and this patch will break 'make disclean', that is >>> why James reverted it. >> >> Last time I did subdir-objects, it broke Centos5. The build farm seems ok >> with it though (the current Centos5 failure is a unit test failure). >> >> I this works on our supported platforms, I'm +1 >> >>> >>> >>> On Fri, Oct 25, 2013 at 11:20 AM, <z...@apache.org> wrote: >>> >>>> Updated Branches: >>>> refs/heads/master 9dcd00b8f -> 2482196f9 >>>> >>>> >>>> automake 1.14 need subdir-objects >>>> >>>> >>>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo >>>> Commit: >>>> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/2482196f >>>> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/2482196f >>>> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/2482196f >>>> >>>> Branch: refs/heads/master >>>> Commit: 2482196f95da58e8b82e17ea8be4435dd648c4e7 >>>> Parents: 9dcd00b >>>> Author: Zhao Yongming <ming....@gmail.com> >>>> Authored: Fri Oct 25 11:17:08 2013 +0800 >>>> Committer: Zhao Yongming <ming....@gmail.com> >>>> Committed: Fri Oct 25 11:17:08 2013 +0800 >>>> >>>> ---------------------------------------------------------------------- >>>> configure.ac | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> ---------------------------------------------------------------------- >>>> >>>> >>>> >>>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/2482196f/configure.ac >>>> ---------------------------------------------------------------------- >>>> diff --git a/configure.ac b/configure.ac >>>> index b4fda1b..5efb1aa 100644 >>>> --- a/configure.ac >>>> +++ b/configure.ac >>>> @@ -40,7 +40,7 @@ AC_PREREQ([2.59]) >>>> AC_CONFIG_AUX_DIR([build/aux]) >>>> AC_CONFIG_SRCDIR([proxy/Main.cc]) >>>> AC_CONFIG_MACRO_DIR([build]) >>>> -AM_INIT_AUTOMAKE([-Wall -Werror tar-ustar foreign no-installinfo >>>> no-installman 1.9.2]) >>>> +AM_INIT_AUTOMAKE([-Wall -Werror tar-ustar foreign no-installinfo >>>> no-installman subdir-objects 1.9.2]) >>>> AC_CONFIG_HEADERS([lib/ts/ink_autoconf.h]) >>>> >>>> # Configure with --disable-silent-rules to get verbose output. For more >>>> info, see >>>> >>>> >>> >>> >>> -- >>> Yunkai Zhang >>> Work at Taobao >> >
