On Aug 22, 2013, at 9:35 AM, Leif Hedstrom <zw...@apache.org> wrote:
> On Aug 22, 2013, at 10:11 AM, James Peach <jpe...@apache.org> wrote:
>
>> On Aug 21, 2013, at 5:51 PM, 永豪 <yong...@taobao.com> wrote:
>>
>>> things I'd like to keep:
>>> 1, feature should be outlined, and should keep revolution in a user
>>> friendly way
>>> 2, provide basic system 'it just work'
>>> 3, user interface changing should get more review before we can release
>>> into public
>>
>> Yes, I strongly agree with all 3 of these points, though I don't think this
>> particular commit is too problematic, particularly since we never actually
>> installed the example_alarm_bin.sh script :)
>>
>> I looked at the alarm documentation and there's a few things that we can
>> improve:
>>
>> - the docs still reference example_alarm_bin.sh though it no longer
>> exists
>> - the docs reference proxy.config.alarm_email, though it's no longer
>> clear what this is for
>
> Yeah, proxy.config.alarm_email is no longer used, and unless we back out this
> commit, we should remove it.
>
> So, I'm asking now for consensus, with two options:
>
> 1) We restore the old behavior, which passed the email address on the command
> line to the alarm script. I'd still argue that this old behavior simply did
> not "just work", it basically "just failed miserably".
>
> 2) We keep the commit, but also remove proxy.config.alarm_email (cause it's
> unused right now).
+1
> The improvements James points out are great, lets file an RFE on those. For
> example, there's nothing right now preventing someone from contributing a
> much better alarms.sh script. Or several of them, for different use cases,
> and something that actually does work.
>
> Please voice your opinions asap, I'd like to get this resolved by tomorrow
> (Friday) morning.
Let's not revert, let's improve.
I will commit a change to add a new configuration option
proxy.config.alarm.arguments that contains a string of arguments that get
passed to the the alarm script. The final invoked command will be:
"%s/%s %s %s %s", proxy.config.alarm.abs_path, proxy.config.alarm.bin,
proxy.config.alarm.arguments, description, alarm
Then I will commit a variation of the original emailing script as a default.
IMHO this supports the original use case, actually works out of the box for
clean installations, and makes sense for sites that don't want this to be
emailed.
J
