Sure, that code is your world so whatever makes the most sense.
Brian
On Wed, May 1, 2013 at 1:15 PM, Alan M. Carroll <a...@network-geographics.com
> wrote:
> I may teak that to use ats_is_ip_any() rather than having a bool flag.
>
> Wednesday, May 1, 2013, 1:51:23 PM, you wrote:
>
> > Yes, this patch is already committed to 3.3.x/Master. Below is a patch
> > that will cleanly apply to 3.2.0.
>
>
> > Brian
>
>
> > --- iocore/net/UnixConnection.cc 2012-06-14 13:50:54.000000000
> -0700
> > +++ iocore/net/UnixConnection.cc 2012-10-16 14:45:43.000000000
> -0700
> > @@ -223,6 +223,7 @@
> > // address family for socket creation.
> > ink_zero(local_addr);
>
> > + bool is_any_address = false;
> > if (NetVCOptions::FOREIGN_ADDR == opt.addr_binding ||
> > NetVCOptions::INTF_ADDR == opt.addr_binding
> > ) {
> > @@ -236,6 +237,7 @@
> > // No local address specified, so use family option if possible.
> > family = ats_is_ip(opt.ip_family) ? opt.ip_family : AF_INET;
> > local_addr.setToAnyAddr(family);
> > + is_any_address = true;
> > local_addr.port() = htons(opt.local_port);
> > }
>
> > @@ -297,8 +299,10 @@
> > // apply dynamic options
> > apply_options(opt);
>
> > - if (-1 == socketManager.ink_bind(fd, &local_addr.sa,
> > ats_ip_size(&local_addr.sa)))
> > - return -errno;
> > + if (local_addr.port() || !is_any_address) {
> > + if (-1 == socketManager.ink_bind(fd, &local_addr.sa,
> > ats_ip_size(&local_addr.sa)))
> > + return -errno;
> > + }
>
> > cleanup.reset();
> > is_bound = true;
>
>
>
> > On Wed, May 1, 2013 at 11:40 AM, Aidan McGurn
> > <aidan.mcg...@owmobility.com>wrote:
>
> >> Re:
> >>
> http://mail-archives.apache.org/mod_mbox/trafficserver-dev/201210.mbox/%3ccafkfyq7kj_mgkcq5wx6umq46ujyxogfszgjvf_0fi7b90oj...@mail.gmail.com%3E
> >> ****
>
> >> ** **
>
> >> Hi Brian –****
>
> >> We are experiencing a similar issue here with EADDRNOTAVAIL occurring
> >> under low load with no port exhaustion –****
>
> >> I was wondering if you had committed the above change ? what the commit
> >> number/TS issue number is and to which codeline –****
>
> >> We currently are using ATS 3.2.0 – Seems like a simple patch as such but
> >> would be re-assuring if you have already committed it and its been
> >> used/tested.****
>
> >> Thanks,****
>
> >> /aidan****
>
> >> The information and attachments contained in this email are intended for
> >> use by the named recipient only and are confidential, privileged and/or
> >> protected by intellectual property rights. You are hereby notified that
> any
> >> use, dissemination, disclosure, distribution, copying or storage of this
> >> information is strictly prohibited. If you have received this
> information
> >> in error, please notify the sender by return email and delete the
> >> electronic transmission, including all attachments, from your system.
>
>
>
