On 24 Apr 2013, at 15:43, Leif Hedstrom wrote: > On 4/24/13 6:51 AM, Nick Kew wrote: >> On Fri, 19 Apr 2013 22:54:47 +0100 >> Nick Kew <n...@apache.org> wrote: >> >> >>> I'll attach a mini demo-plugin that reproduces the problem. >>> The essence of it can be boiled down to: >> Magic sauce here. > > Indeed. I hate magic. > > So, since for sure the regressions are hanging now, should we back out the > commit, until we can figure out one of two things:
Yeah, OK. It was after yesterday's session on IRC I wondered if a reader might retain a pointer that was lost in the iobuf. Obviously that couldn't happen if the pointer was already lost before the reader was initialised. But in this case, a bit of voodoo worked! Some possible solutions: - Insist that a reader is initialised before writing data to the buffer. - Retain a pointer to all (not-yet-consumed) data in the iobuf. -- Nick Kew
