----- Original Message -----
> TS-1820 Introduce TS_UNUSED, and migrate most of the code to use
> either C++ style unused parameters, or this new macro
[snip]
> Commit: e343dbbc60819256e8db7bc0d1f0ae7a4067c7cf
> Parents: 3840df1
[snip]
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e343dbbc/example/add-header/add-header.c
> ----------------------------------------------------------------------
> diff --git a/example/add-header/add-header.c
> b/example/add-header/add-header.c
> index c0fd6f4..a329162 100644
> --- a/example/add-header/add-header.c
> +++ b/example/add-header/add-header.c
> @@ -35,13 +35,15 @@
> #include <ctype.h>
> #include <stdio.h>
> #include <string.h>
> -#include <ts/ts.h>
> +
> +#include "ts/ts.h"
> +#include "ink_defs.h"
You don't mention this conversion in the comments, what's the motivation behind
it?
[snip]
> @@ -232,7 +236,7 @@ check_ts_version()
> }
>
> void
> -TSPluginInit(int argc, const char *argv[])
> +TSPluginInit(int argc ATS_UNUSED, const char *argv[] ATS_UNUSED)
> {
> int i, cc;
> TSPluginRegistrationInfo info;
Your commit message says TS_UNUSED, but you use ATS_UNUSED
Perhaps we should once and for all document when to use ts_ and when ats_
https://cwiki.apache.org/confluence/display/TS/Coding+Style
-- i
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: [email protected]
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
