On Apr 17, 2013, at 4:37 AM, Nick Kew <n...@apache.org> wrote: > On Mon, 15 Apr 2013 16:35:35 -0600 > Leif Hedstrom <zw...@apache.org> wrote: > >> The goal is to release this on April 18th, so please cast your +, - or 0 >> votes asap. > > -1. Won't compile for me: > > cc1plus: warnings being treated as errors > RecUtils.cc:79: error: integer constant is too large for ‘long’ type > RecUtils.cc:101: error: integer constant is too large for ‘long’ type > make[2]: *** [libreclocal_a-RecUtils.o] Error 1 > > > This is a regression, introduced in > https://git-wip-us.apache.org/repos/asf/trafficserver/?p=trafficserver.git;a=commitdiff;h=5bcc19e6e901e7115bfbbcc6b4b8f60dfc51f4a7 > (March 12th). > > Looks like it needs a LONG_MAX construct. Or an explicitly-sized type. > Surely I can't be the only one on 32 bits?
I just built and ran regressions on the quantal32 vagrant box. What platform and toolchain are you using? > > Manually fixing those constants, all else is well. > It passes make test, and runs as a drop-in update and is > binary-compatible with my existing ironbee binaries. > > -- > Nick Kew
