On 09/04/2013, at 7:06 PM, Yunkai Zhang <yunkai...@gmail.com> wrote: > And I think, we are talking to TS-1805:)
yes we are ;) > > > On Wed, Apr 10, 2013 at 9:59 AM, Yunkai Zhang <yunkai...@gmail.com> wrote: > Hi James: > > The attached patch is good for me, thanks for your review. > > > On Wed, Apr 10, 2013 at 4:58 AM, James Peach <jpe...@apache.org> wrote: > Hi Yunkai, > > Leif and I reviewed the TS-1801 changes today. It looks good, though we have > one suggestion in NodeStatEval(), where there seems to be a possibility that > the result_type would not be set correctly. Do you think that the attached > patch is correct? > > > > > J > > > > > > > -- > Yunkai Zhang > Work at Taobao > > > > -- > Yunkai Zhang > Work at Taobao
