On Jan 31, 2013, at 12:26 AM, Igor Galić <i.ga...@brainsware.org> wrote:
> On Thursday, January 31, 2013 04:31:57 AM jpe...@apache.org wrote: >> Updated Branches: >> refs/heads/master 0514ba2ab -> 529d1bd27 >> >> >> TS-1650: fix enum Net_Stats >> >> >> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo >> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/529d1bd2 >> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/529d1bd2 >> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/529d1bd2 >> >> Branch: refs/heads/master >> Commit: 529d1bd2760502392678df1d552a0d2949da5ab3 >> Parents: c46ac44 >> Author: James Peach <jpe...@apache.org> >> Authored: Wed Jan 30 20:31:38 2013 -0800 >> Committer: James Peach <jpe...@apache.org> >> Committed: Wed Jan 30 20:31:38 2013 -0800 >> >> ---------------------------------------------------------------------- >> iocore/net/P_Net.h | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> ---------------------------------------------------------------------- >> >> >> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/529d1bd2/iocore/ne >> t/P_Net.h >> ---------------------------------------------------------------------- diff >> --git a/iocore/net/P_Net.h b/iocore/net/P_Net.h >> index 3445626..39a49af 100644 >> --- a/iocore/net/P_Net.h >> +++ b/iocore/net/P_Net.h >> @@ -55,8 +55,8 @@ enum Net_Stats >> socks_connections_successful_stat, >> socks_connections_unsuccessful_stat, >> socks_connections_currently_open_stat, >> - Net_Stat_Count, >> - inactivity_cop_lock_acquire_failure_stat >> + inactivity_cop_lock_acquire_failure_stat, >> + Net_Stat_Count >> }; >> >> struct RecRawStatBlock; > > > Ah, put it at the end, so we don't break ABIs. Net_Stat_Count is used to size stats blocks. It was triggering an assert in debug regressions. I didn't check for and ABI impact. > btw, why don't we use trailing , in arrays/lists? Some compilers puke on that J
