> > 
> > Hey folks,
> > 
> > I was wondering how many of you use UTF-8 as your default
> > Character encoding and would like to see Traffic Server
> > use it by default as well.
> 
> There's a confusing divergence of responses to the two lists!

Having lost most mail from the last two months, up until
yesterday, I'll just have to believe you.
 
> > I have a tiny patchset which switches from the old default
> > latin1 to the utf-8 up on my github:
> > 
> >   https://github.com/igalic/trafficserver/tree/utf-8
> 
> An actual patch would be easier to review.
> Your "utf-8" changes appear to span more than one commit.

Attached.


> --
> Nick Kew

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.ga...@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE

From ae8701fdd15a3565a61ed611cd5283e5119344bc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Igor=20Gali=C4=87?= <i.ga...@brainsware.org>
Date: Tue, 4 Dec 2012 00:09:48 +0100
Subject: [PATCH 2/2] Switch charset to UTF-8 in HttpTransactionCache

---
 proxy/http/HttpTransactCache.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git proxy/http/HttpTransactCache.cc proxy/http/HttpTransactCache.cc
index fec89af..907e24f 100644
--- proxy/http/HttpTransactCache.cc
+++ proxy/http/HttpTransactCache.cc
@@ -620,7 +620,7 @@ HttpTransactCache::calculate_quality_of_accept_charset_match(MIMEField * accept_
   char c_charset[128];
   char *a_charset;
   int a_charset_len;
-  const char *default_charset = "iso-8859-1";
+  const char *default_charset = "utf-8";
   bool wildcard_present = FALSE;
   float wildcard_q = 1.0;
 
-- 
1.7.11.7

From f8f0aa2b711ac79984b530c236f611ebfeffc131 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Igor=20Gali=C4=87?= <i.ga...@brainsware.org>
Date: Thu, 29 Nov 2012 07:49:21 +0100
Subject: [PATCH 1/2] Change the default charset to UTF-8

In 2012, let's lead with example and make UTF-8 our default
charset - especially since we have such a big customer base
in all over the world.
---
 proxy/config/body_factory/default/.body_factory_info | 2 +-
 proxy/http/HttpBodyFactory.cc                        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git proxy/config/body_factory/default/.body_factory_info proxy/config/body_factory/default/.body_factory_info
index a8a651e..e07e021 100644
--- proxy/config/body_factory/default/.body_factory_info
+++ proxy/config/body_factory/default/.body_factory_info
@@ -13,4 +13,4 @@
 #	Content-Charset: iso-2022-kr
 #
 # If this file is empty, or only contains comments, the default is
-# assumed: English text in the standard iso-8859-1 character set.
+# assumed: English text in the standard utf-8 character set.
diff --git proxy/http/HttpBodyFactory.cc proxy/http/HttpBodyFactory.cc
index b425dfb..a256962 100644
--- proxy/http/HttpBodyFactory.cc
+++ proxy/http/HttpBodyFactory.cc
@@ -871,7 +871,7 @@ HttpBodySet::init(char *set, char *dir)
       this->content_language = ats_strdup(set);
   }
   if (!this->content_charset)
-    this->content_charset = ats_strdup("iso-8859-1");
+    this->content_charset = ats_strdup("utf-8");
 
   close(fd);
   return (lines_added);
-- 
1.7.11.7

Reply via email to