Thing is: if this code made it to 3.2, I'd like to fix it James Peach <jpe...@apache.org> wrote:
>On 19/09/2012, at 3:09 PM, Leif Hedstrom <zw...@apache.org> wrote: > >> On 9/18/12 10:29 PM, James Peach wrote: >>> On 18/09/2012, at 9:16 PM, Mladen Turk <mt...@apache.org> wrote: >>> >>>> On 09/19/2012 02:02 AM, Igor Galić wrote: >>>>> >>>>> On Solaris this got me through the CPU affinity stuff, but hung >on: >>>>> >>>>> "SplitDNS.cc", line 639: Error: Could not find a match for >ink_atomic_cas(SplitDNSConfigInfo**, SplitDNSConfigInfo*, >SplitDNSConfigInfo*) needed in SplitDNSConfigProcessor::set(unsigned, >SplitDNSConfigInfo*). >>>>> >>>> Think that's the casting issue. >>>> ink_atomic_cas is declared as ink_atomic_cas(void **, void *, void >*) >>>> so that won't work without explicit casting. >>> Yep. For all platforms except Solaris I changed ink_atomic_cas over >to be a template so that casting would not be required. If this is >building with GCC on solaris, then the existing template implementation >will work, otherwise it will be more interesting :) >> >> >> I thought we agreed to drop explicit support for Oracle's SunStudio >compilers? > >Great! I didn't see that written down anywhere ... > >J -- I
