On 6 June 2012 22:04, Igor Galić <i.ga...@brainsware.org> wrote: > > > ----- Original Message ----- >> On 6 June 2012 20:47, Igor Galić <i.ga...@brainsware.org> wrote: >> > >> >> >> > Is there any way we can fix this code to use something like >> >> >> > LWP? >> >> >> >> >> >> In theory yes, but someone has to do the work. >> >> > >> >> > Can you tell me where that script lives? >> >> >> >> https://svn.apache.org/repos/asf/infrastructure/site-tools/trunk/projects/scripts/projects.pl >> > >> > >> > I think I'm mostly done. >> > >> > This is completely untested: >> > >> > http://sprunge.us/CPNh >> >> AFAICT from a quick scan of the code, it just won't work. >> The GET parameter is wrong, but easily fixed. >> >> The Get procedure expects a socket as first parameter; that cannot >> just be dropped. >> >> Also, the rest of the code reuses the socket if possible to reduce >> connection overhead. > > Here's a clean-up that fixes syntax errors and typos, it's only > "tested" with perl -c. All calls to socket* in and around Get() > have been removed. > > http://sprunge.us/HWYH
Again, it almost certainly won't work. For example: - $failed++, next unless $socket; - $rv = Get($socket, $d, $host, $tried); + $failed++, next; + $rv = Get($d, $host, $tried); # <<< Can never reach this line > i > > -- > Igor Galić > > Tel: +43 (0) 664 886 22 883 > Mail: i.ga...@brainsware.org > URL: http://brainsware.org/ > GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE >
