----- Original Message -----
>
>
> ----- Original Message -----
> > Updated Branches:
> > refs/heads/master a79a638d8 -> 53ebc2f72
> >
> >
> > TS-672 cleanup Win32 references
> >
> > nuke win32 completely.
> [snip]
> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/53ebc2f7/mgmt/api/include/mgmtapi.h
> > ----------------------------------------------------------------------
> > diff --git a/mgmt/api/include/mgmtapi.h
> > b/mgmt/api/include/mgmtapi.h
> > index bc4ca0b..8f51e97 100644
> > --- a/mgmt/api/include/mgmtapi.h
> > +++ b/mgmt/api/include/mgmtapi.h
> > @@ -39,21 +39,10 @@
> > * System Specific Items
> >
> > ***************************************************************************/
> >
> > -#if defined (_WIN32) && defined (_TS_EXPORT)
> > -#define tsapi __declspec( dllexport )
> > -#elif defined (_WIN32)
> > -#define tsapi __declspec( dllimport )
> > -#else
> > #define tsapi
> > -#endif
> >
> > -#if defined (_WIN32)
> > -#define inkexp __declspec( dllexport )
> > -#define inkimp __declspec( dllimport )
> > -#else
> > #define inkexp
> > #define inkimp
> > -#endif
> >
> > #if !defined(linux)
> > #if defined (__SUNPRO_CC) || (defined (__GNUC__) || !
> > defined(__cplusplus))
> >
>
> aside from making certain things more obvious, this macro only
> existed for the sake of WIN32. Now, I still think it makes sense
> to retain it, because it still makes these things more obvious,
> and also because one day we might want to try and port ATS to
> Windows again ;)
After your cleanup, this is what we're still left with:
-->8-------------
mgmt/web2/WebHttp.cc:203: // access the .so/.dll plugin files.
example/add-header/add-header.c:29: * (NT): AddHeader.dll "name1: value1"
"name2: value2" ...
example/thread-pool/psi.c:29: * (NT): psi.dll
example/bnull-transform/bnull-transform.c:30: * (NT): BNullTransform.dll
example/append-transform/append-transform.c:32: * (NT): AppendTransform.dll
<filename>
example/redirect-1/redirect-1.c:30: * (NT): Redirect.dll block_ip url_redirect
example/thread-1/thread-1.c:29: * (NT): Thread.dll
example/null-transform/null-transform.c:30: * (NT): NullTransform.dll
example/server-transform/server-transform.c:30: * (NT):
ServerTransform.dll
example/file-1/file-1.c:29: * (NT): File.dll <filename1> <filename2> ...
proxy/http/TestUrl.cc:118:
create_url("www.microsoft.com/isapi/redir.dll?TARGET=%2Foffice%2Fmigration%2F&nonie3home&homepage&&&&headline1&1006");
proxy/Plugin.cc:132: handle = dll_open(path, (internal ? true : false));
proxy/Plugin.cc:134: Error("unable to load '%s': %s", path,
dll_error(handle));
proxy/Plugin.cc:138: lic_req = (lic_req_func_t) dll_findsym(handle,
"TSPluginLicenseRequired");
proxy/Plugin.cc:143: dll_close(handle);
proxy/Plugin.cc:153: init_func_w_handle_t inith = (init_func_w_handle_t)
dll_findsym(handle, "TSPluginInitwDLLHandle");
proxy/Plugin.cc:159: init = (init_func_t) dll_findsym(handle, "TSPluginInit");
proxy/Plugin.cc:161: Error("unable to find TSPluginInit function '%s': %s",
path, dll_error(handle));
proxy/Plugin.cc:162: dll_close(handle);
proxy/Plugin.cc:170: //dll_close(handle);
-----8<----------
I don't think the stuff in Plugin.cc or TestUrl.cc counts
and the examples are harmless.
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.ga...@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
