With r1174513 I've cleaned out the last bit of sensibly
cleanable code. -- Three things are left:

* ink_strncpy()/ink_strncat()
  I'm considering to change the function definitions so they will
  kindly suggest (rad as: #error) to use ink_strlcpy/ink_strlcat()

* lib/ts/mkdfa.c
  lib/ts/ink_string.h is not C-clean. If I include it in lib/ts/mkdfa.c
  I'll get:

  In file included from ink_error.h:39:0,
                 from ink_string.h:40,
                 from mkdfa.c:30:
  ink_defs.h:90:1: error: unknown type name ‘namespace’
  ink_defs.h:90:14: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ 
before ‘{’ token
  In file included from ink_string.h:41:0,
                 from mkdfa.c:30:
  ParseRules.h:80:1: error: unknown type name ‘class’
  ParseRules.h:81:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ 
before ‘{’ token
  ParseRules.h:181:11: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ 
before ‘:’ token


* proxy/PluginDB.cc
  strncat/strncpy are used in the licensing code. That's very
  convenient, because I'm planning to throw that code out. See:
  
http://mail-archives.apache.org/mod_mbox/trafficserver-dev/201109.mbox/%3c1a38eab2-af75-4cd9-bdda-b481155d519c@iris%3e

i

--
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.ga...@brainsware.org
URL: http://brainsware.org/
GPG: 571B 8B8A FC97 266D BDA3  EF6F 43AD 80A4 5779 3257

Reply via email to