I agree (re running the script).

We should also have emacs and vim configurations.
I think Leif had a emacs one somewhere and I wonder if it
has that option set.

john


On 5/9/2010 1:26 AM, Mladen Turk wrote:
> Hi,
> 
> According to the style guide and 'best practice'
> there should be no trailing spaces in the code.
> 
> Any descent editor has 'Trim trailing spaces on save'
> option and modifying editor preferences just for editing the
> code could be a hassle, cause those formatting edits
> could be intermixed with real code change otherwise.
> 
> 
> For example:
> $ cd iocore/cache
> $ grep -n -e '[[:space:]]$' *.cc | wc -l
> 
> gives about 150 lines having trailing spaces
> 
> This can be easily fixed with a simple script:
> #!/bin/sh
> for f
> do
>   case "$f" in
>     * )
>       sed -e 's/[[:space:]]*$//g' $f > $f.tmp
>       rm -f $f
>       mv $f.tmp $f
>     ;;
>   esac
> done
> 
> Think we should fix that in a batch for all files
> in a single commit.
> 
> Comments?
> 
> 
> Regards

Reply via email to