On 03/16/2010 08:25 AM, Leif Hedstrom wrote:
Hi,
I was looking at this the other day, and I'm wondering if we shold
"coalesce" all these defines into one, i.e. make INK_SDK_VERSION_5_2
be named TS_SDK_VERSION_2_0 ? We could also keep the
INK_SDK_VERSION_5_2, but remove all the earlier ones with the same
define as TS_SDK_VERSION_2_0. I don't see any reason why we should
need to keep any of the older versions (since they are all Inktomi
legacy stuff), and INK_SDK_VERSION_5_5 is never used anywhere in the
code (so that should definitely be removed).
Eh, that sentence got garbled, it should read:
We could also keep the INK_SDK_VERSION_5_2, but remove all the earlier
ones completely and not preserve those defines. I don't see any reason
why we should need to keep any of the older versions (since they are all
Inktomi legacy stuff), and INK_SDK_VERSION_5_5 is never used anywhere in
the code (so that should definitely be removed).
Adding on to this thread, the new enum looking something like this:
typedef enum
{
TS_SDK_VERSION_2_0 = 0,
TS_SDK_VERSION_3_0,
INK_SDK_VERSION_5_2 = 0
} INKSDKVersion;
It's kinda ugly that it's still named INKSDKVersion, but I don't think
we should change that right now (to keep it compatible with docs and any
code people might have written already). What we could do is to add the
new enum right now, i.e.
typedef enum
{
TS_SDK_VERSION_2_0 = 0,
TS_SDK_VERSION_3_0,
} TSSDKVersion;
-- Leif
