[ 
https://issues.apache.org/jira/browse/TS-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843724#action_12843724
 ] 

John Plevyak commented on TS-158:
---------------------------------

312 is

  return (dir_tag(e) == DIR_MASK_TAG(key->word(2)));

both of which should be unsigned:

#define dir_tag(_e) ((_e)->w[2]&((1<<DIR_TAG_WIDTH)-1))

where   inku16 w[5];

and MD5 word returns inku32

and 

#define DIR_MASK_TAG(_t)                ((_t) & ((1 << DIR_TAG_WIDTH) - 1))

???


> cache should not hold parititon lock over callbacks/review locking
> ------------------------------------------------------------------
>
>                 Key: TS-158
>                 URL: https://issues.apache.org/jira/browse/TS-158
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Cache
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.0
>
>
> Because we now have far fewer partitions it would be best
> not to hold the partition lock over callbacks to reduce contention
> on this lock and enable better scaling.
> This is a good opportunity to review the locking in the cache as
> well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to