[
https://issues.apache.org/jira/browse/TS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Plevyak updated TS-38:
---------------------------
Attachment: ts-64-bit-warning.patch
This patch fixes the bug and also cleans up some bare "unsigned" types.
Because this code is does bit manipulation on pointers and because the 64-bit
port required differentiating between those things
which could contain pointers from those that could not and because prior to
x86_64 the codebase
assumed that the native size int was the same size as pointers (which was true
for the Alpha,
HPUX and AIX) and so used "unsigned" or "unsigned int" instead of uintptr_t I
think it more prudent
to use inkXXX types in this code to mark those variables which are not used to
hold pointer size things.
I chose inku32 under the assumption that we wouldn't have more than 4G of any
one type of object
which might not hold true forever, but it does mean that the generated code is
the same as now which
makes the patch safer.
> ubuntu 8.04 x86_64 w/ gcc 4.2.4
> --------------------------------
>
> Key: TS-38
> URL: https://issues.apache.org/jira/browse/TS-38
> Project: Traffic Server
> Issue Type: Bug
> Components: Portability
> Environment: ubuntu 8.04 x86_64 w/ gcc 4.2.4
> Reporter: John Plevyak
> Priority: Minor
> Attachments: ts-64-bit-warning.patch
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> Warnings prevent compilation on this platform. Some casts need to be cleaned
> up.
> c1plus: warnings being treated as errors
> ../../libinktomi++/ink_queue.cc: In function 'void
> ink_freelist_init(InkFreeList*, const char*, unsigned int, unsigned int,
> unsigned int, unsigned int)':
> ../../libinktomi++/ink_queue.cc:136: warning: NULL used in arithmetic
> ../../libinktomi++/ink_queue.cc: In function 'void
> ink_atomiclist_init(InkAtomicList*, const char*, unsigned int)':
> ../../libinktomi++/ink_queue.cc:531: warning: NULL used in arithmetic
> ../../libinktomi++/ink_queue.cc: In function 'void*
> ink_atomiclist_popall(InkAtomicList*)':
> ../../libinktomi++/ink_queue.cc:582: warning: NULL used in arithmetic
> make[1]: *** [ink_queue.o] Error 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
