henry-lindeman-glean commented on PR #3278: URL: https://github.com/apache/tika/pull/3278#issuecomment-6048651751
those all look reasonable. ran more ai reviews on my own too. One thing it came up with I didn't take since the fix would be in tika-core and seems like it's known and the failure case is kinda pathological anyway: ``` Quadratic publish at the cap (security + performance, independently): publish hands 100k values to Metadata.set(Property, String[]), whose limiter appends one-by-one with growing-array copies — ~5·10⁹ reference copies cumulative (~20 GB churn) worst case, executed inside finally where it can delay limit-exception propagation. The cap bounds it but doesn't make it cheap. Decide: lower cap, batch differently, or accept with a comment. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
