dschmidt commented on PR #3118: URL: https://github.com/apache/tika/pull/3118#issuecomment-5516381986
My agent was a bit quick to post a response I didn't want him to, sorry about that. Here's my handwritten response: I like this a lot - it feels way more natural than the thumbnails specific config: no allowPerRequestConfig, content resolved worker side, and a path a proxy can filter on. Just one remark for the UnpackSelector discussed in my PR (not because it's part of this, but because it's the other half of the desired functionality): the select function has no lookahead, so we can't decide between two THUMBNAIL files. So for example when we have an embedded .emf file and its rendering, with this API we can't know which to pick. We could make the rendering the only thumbnail and mark the original file as INLINE/ATTACHMENT, but then the resource type depends on the request parameters which is kinda weird. P.S.: I'm happy to provide the maxRenderedPages features in a separate standalone PR (or you incorporate it from my PR, however you like) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
