tballison commented on PR #3107:
URL: https://github.com/apache/tika/pull/3107#issuecomment-5482180068
I _think_ I now get why you'd want this. There are actually four places
where this should be fixed.
Could you hoist your resolveDefaultPluginsDir(codeSourceDir, cwd) into
tika-pipes-core next to ConfigMerger, maybe?
||Module / class||Current default resolution||Bug||Action||
||{{TikaServerProcess}} (tika-server-core)|jar dir only, then
CWD-relative|misses lib/ layout
(TIKA-4864)|fixed by PR #3107; route through shared helper|
||{{PipesForkParser}} (tika-pipes-fork-parser)|jar dir only, then
CWD-relative|same miss of lib/
layout|replace copy with shared helper|
||{{TikaAsyncCLI}} (tika-async-cli)|parent of jar dir only, then
CWD-relative|misses jar-adjacent layout;
also used by {{PluginsWriter}}|replace copy with shared helper|
||{{TikaGrpcServerImpl}} (tika-grpc)|none — requires config/--plugin-roots;
on missing plugin-roots falls
back to bare pf4j {{DefaultPluginManager}} (CWD-relative)|fallback
contradicts its own WARN text ("next to
tika-grpc.jar")|optional: use shared helper in the fallback|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
