dschmidt commented on code in PR #3093:
URL: https://github.com/apache/tika/pull/3093#discussion_r3886882222
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/epub/EpubParser.java:
##########
@@ -442,6 +448,10 @@ private void handleEmbedded(ZipFile zipFile, String
relativePath, HRefMediaPair
embeddedMetadata.set(HttpHeaders.CONTENT_TYPE,
hRefMediaPair.media);
}
embeddedMetadata.set(TikaCoreProperties.RESOURCE_NAME_KEY, fullPath);
+ if (cover) {
+ embeddedMetadata.set(TikaCoreProperties.EMBEDDED_RESOURCE_TYPE,
+
TikaCoreProperties.EmbeddedResourceType.THUMBNAIL.toString());
+ }
Review Comment:
Good catch (pre-existing, but this path reaches it more easily now): guarded
the font check against a null media type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
