[
https://issues.apache.org/jira/browse/TIKA-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109438#comment-18109438
]
ASF GitHub Bot commented on TIKA-4853:
--------------------------------------
Copilot commented on code in PR #3092:
URL: https://github.com/apache/tika/pull/3092#discussion_r3886824982
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-cad-module/src/test/java/org/apache/tika/parser/dwg/DWGParserTest.java:
##########
@@ -276,16 +276,17 @@ public void testDWGReadexe() throws Exception {
assertNotNull(root.get(DWG.APPLICATION_COMMENT));
assertContains("AutoCAD", root.get(DWG.PRODUCT_INFO));
- // Thumbnail embedded as INLINE
+ // the THUMBNAILIMAGE section is the drawing's THUMBNAIL embedded
document
Review Comment:
For consistency with nearby comments in this test, capitalize the start of
this sentence.
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-cad-module/src/main/java/org/apache/tika/parser/dwg/DWGReadParser.java:
##########
@@ -416,8 +416,9 @@ private void parseThumbnail(JsonParser jsonParser,
XHTMLContentHandler xhtml,
EmbeddedDocumentUtil.getEmbeddedDocumentExtractor(context);
Metadata embeddedMetadata = new Metadata();
embeddedMetadata.set(TikaCoreProperties.RESOURCE_NAME_KEY,
"thumbnail");
+ //the drawing's preview image, not a picture placed in the drawing
Review Comment:
Comment style is inconsistent with the rest of the file: there should be a
space after `//` and the sentence should start with a capital letter.
> DWGReadParser emits the drawing thumbnail as INLINE instead of THUMBNAIL
> ------------------------------------------------------------------------
>
> Key: TIKA-4853
> URL: https://issues.apache.org/jira/browse/TIKA-4853
> Project: Tika
> Issue Type: Improvement
> Reporter: Dominik Schmidt
> Priority: Major
>
> DWGReadParser extracts the THUMBNAILIMAGE section and emits it as an embedded
> document named "thumbnail", but with tk:embedded-resource-type=INLINE
> (DWGReadParser.java:419). It is the drawing's preview image, not a picture
> placed in the drawing, so it should be THUMBNAIL, consistent with the other
> container parsers. One-line change plus a test assertion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
