[
https://issues.apache.org/jira/browse/TIKA-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109074#comment-18109074
]
ASF GitHub Bot commented on TIKA-4849:
--------------------------------------
theit opened a new pull request, #3088:
URL: https://github.com/apache/tika/pull/3088
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
This PR fixes [TIKA-4849: Unnecessary dependencies to
jaxb-runtime](https://issues.apache.org/jira/browse/TIKA-4849):
Two parser modules (tika-parser-miscoffice-module and
tika-parser-pdf-module) still contain a depenency to jaxb-runtime although this
isn't needed (anymore).
I verified that the build still works by executing "mvn clean verify" on my
fork.
> Unnecessary dependencies to jaxb-runtime
> ----------------------------------------
>
> Key: TIKA-4849
> URL: https://issues.apache.org/jira/browse/TIKA-4849
> Project: Tika
> Issue Type: Improvement
> Components: dependency, parser
> Affects Versions: 4.0.0
> Reporter: Thorsten Heit
> Priority: Minor
>
> The parser modules "tika-parser-miscoffice-module" and
> "tika-parser-pdf-module" both contain a dependency to
> org.glassfish.jaxb:jaxb-runtime. This should be removed because it's not
> needed (anymore?) and used in the code.
> The pdf module contains the following comment snippet in its {{pom.xml}}:
> {noformat}
> <!-- for java 10
> See TIKA-2778 for why we need to do this now.
> May the gods of API design fix this in the future.
> only required for jackcess-encrypt
> -->
> <dependency>
> <groupId>org.glassfish.jaxb</groupId>
> <artifactId>jaxb-runtime</artifactId>
> </dependency>
> {noformat}
> Obviously there was a a reason for adding the depenency, but according to
> {{mvn dependency:tree}} the mentioned "jackcess-encrypt" isn't contained in
> the (transitive) list of dependencies, for both of the above mentioned
> modules.
> "mvn clean verify" with the dependency removed on the modules works btw.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
