dschmidt commented on PR #2953: URL: https://github.com/apache/tika/pull/2953#issuecomment-4981499808
1. was a leftover from an earlier iteration that scanned raw bytes for sinf; the javadoc now names only the protected sample entry formats. 2. I think the asymmetry is the correct semantics rather than an accident: has-drm answers "does this file contain protected audio anywhere", so any track sets it, while bitrate describes one stream and follows the same last-sound-track convention as the rest of the MP4 audio metadata. Both javadocs now state their multi-track semantics explicitly. 3. is deliberate: the property is defined as the average, and deriving one from maxBitrate would report a number the encoder never claimed; a separate max-bitrate property would be the clean extension if anyone ever needs it. 4. agreed, leaving as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
