vasiliy-mikhailov commented on PR #2917: URL: https://github.com/apache/tika/pull/2917#issuecomment-4851367460
Thanks @tballison, great feedback. All three are addressed in the latest push: 1. Rewrote the comments to state the behaviour under test and dropped every mutant/line-number reference. You are right that those were tooling exhaust that would rot the first time the production file shifts. 2. Corrected the `customMarkLimit` comment: the meta tag starts at byte 80 (within the limit); it is the charset value that gets truncated at byte 100, so nothing is detected. 3. Added the `0.0f` delta to the `getConfidence()` assertions. Build is green (StandardHtmlEncodingDetectorTest: 40 tests, 0 checkstyle violations). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
