nddipiazza commented on PR #2919: URL: https://github.com/apache/tika/pull/2919#issuecomment-4846126048
Thanks @tballison — addressed both points: 1. **ParseHandler change** — noted it's belt-and-suspenders; kept it since it makes the invariant explicit, but agree it's not the load-bearing fix. 2. **Tests** — removed the 4 tests that didn't exercise the actual changed code (arg-parsing tests in `AsyncCliParserTest`, duplicate config-generation tests in `TikaConfigAsyncWriterTest`). Added `AsyncProcessorTest#testContentOnlyDynamicEmitStrategy` which uses `emitStrategy=DYNAMIC` with a 10 MB threshold so the small test file goes through the passback path — exactly the scenario where the bug manifested. Without the `EmitHandler` fix that test would write JSON; with it, it gets raw text. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
