[ 
https://issues.apache.org/jira/browse/TIKA-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048738#comment-18048738
 ] 

Nicholas DiPiazza commented on TIKA-4611:
-----------------------------------------

Reviewed and approved PR: https://github.com/apache/tika-docker/pull/29

*Changes:*
- Added {{linux/s390x}} to build platforms in {{docker-tool.sh}}
- Added "Supported Platforms" documentation section to {{README.md}}

*Review Summary:*
✅ Clean implementation - simply adds s390x to existing platform list
✅ No breaking changes to existing platforms
✅ Author tested successfully with emulation
✅ Pure Java Tika should work fine on s390x
✅ Solves Solr integration test issues on IBM platforms

Ready to merge once CI passes.

> Add docker support for the IBM s390x architecture
> -------------------------------------------------
>
>                 Key: TIKA-4611
>                 URL: https://issues.apache.org/jira/browse/TIKA-4611
>             Project: Tika
>          Issue Type: Task
>          Components: docker
>            Reporter: Jan Høydahl
>            Priority: Major
>
> The Solr project has currently disabled some integration tests on the IBM 
> s390x platform due to the test depending on running Tika Server in 
> TestContainers, which of course fails on that platform. What actually 
> happened before we explicitly disabled the test was that TestContainers chose 
> to pull the amd64 image, which then failed during start.
> Building for this architecture should be little more than adding a third 
> platform to the existing list in the {{docker-tool.sh}} script. Unless there 
> are components in Tika which use native code or shell scripts that are not 
> compatible, Tika should run fine on this platform too.
> In the Solr project we have some CI tests running on that platform to verify.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to