tombrisland commented on PR #2315: URL: https://github.com/apache/tika/pull/2315#issuecomment-3267289094
Good spot, I think it can definitely be empty, or at least empty of media directories, so definitely worth checking for that. As for where the call goes - sounds better to do it before and pass it through - just a thought: What do you think about adding the major and compatible brands as metadata properties, and then computing the ContentType outside `handleBrands`, either in `parse` or `processMp4Directories`? It struck me as a bit odd that it happens where it does, as it seems like it could be overwritten by multiple metadata directories? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
