If I turn off the automatic module names in the jars, in 2.x, I'm at least able to get tika-core to build correct javadocs from the parent level.
I'm wondering if we're running into problems because the `tika` level doesn't build a jar and therefore doesn't have an Automatic-Module-Name? https://maven.apache.org/plugins/maven-javadoc-plugin/examples/aggregate.html#aggregating-javadocs-for-modularized-projects On Thu, May 29, 2025 at 9:12 AM Tim Allison <talli...@apache.org> wrote: > > On the 2.x branch, javadoc:aggregate works. > > When I move 2.x to build java 11, we get the same behavior we're seeing on > 3.x. > > When I change the release back to 8, javadoc:aggregate works; > > <maven.compiler.release>8</maven.compiler.release> > > On Thu, May 29, 2025 at 6:34 AM Tim Allison <talli...@apache.org> wrote: > > > > When I run javadoc:aggregate on pdfbox, I'm also not seeing the old > > reports/apidocs in {project.directory}/reports/apidocs. I do see > > javadoc jars for individual modules created when I run mvn clean > > release:prepare -DdryRun=true. > > > > Back on Tika, when I add a package-info at the project directory level > > src/main/java/org/apache/tika, I get a complaint that there aren't any > > public classes for javadocs. When I throw in a stub, I get javadocs > > where I expect them, but only for that stub class, not aggregated for > > the full project. > > > > On Thu, May 29, 2025 at 5:28 AM Tim Allison <talli...@apache.org> wrote: > > > > > > > <parent-project>/target/site/apidocs/ i see that is empty > > > > > > Y, exactly. Still not there with your recent merged PR for me either. :( > > > > > > Thank you, though! > > > > > > I tried Dave's recommendation for `javadoc:jar` and got a different > > > info message which is probably the source of the problem for why > > > javadoc:aggregate is not executing at the main (`tika`) level: > > > > > > --- javadoc:3.11.2:jar (default-cli) @ tika --- > > > [INFO] Not executing Javadoc as the project is not a Java > > > classpath-capable package > > > [INFO] > > > ------------------------------------------------------------------------ > > > > > > When I tried javadoc:aggregate-jar, I got this: > > > <<< javadoc:3.11.2:aggregate-jar (default-cli) < compile @ tika <<< > > > [INFO] > > > [INFO] > > > [INFO] --- javadoc:3.11.2:aggregate-jar (default-cli) @ tika --- > > > [INFO] No Javadoc in project. Archive not created. > > > > > > I'm wondering if we need to include a package-info.java file at the main > > > level? > > > > > > On Wed, May 28, 2025 at 8:34 PM Nicholas DiPiazza > > > <nicholas.dipia...@gmail.com> wrote: > > > > > > > > sorry > > > > > > > > <parent-project>/target/site/apidocs/ > > > > > > > > i see that is empty > > > > hmmm will dig > > > > > > > > On Wed, May 28, 2025 at 6:52 PM Nicholas DiPiazza < > > > > nicholas.dipia...@gmail.com> wrote: > > > > > > > > > merged https://github.com/apache/tika/pull/2223 > > > > > > > > > > mvn clean install javadoc:javadoc javadoc:aggregate -DskipTests=true > > > > > > > > > > works for me > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, May 28, 2025 at 5:02 PM Dave Fisher <w...@apache.org> wrote: > > > > > > > > > >> Just a drive by suggestion, but you may want to see what > > > > >> `javadoc:aggregate-jar` does for you. After that a ChatGPT session > > > > >> might > > > > >> help. > > > > >> > > > > >> Best, > > > > >> Dave > > > > >> > > > > >> > On May 28, 2025, at 2:04 PM, Tim Allison <talli...@apache.org> > > > > >> > wrote: > > > > >> > > > > > >> >> and now it ran, however no javadoc file was generated. (which is > > > > >> >> also > > > > >> mentioned in TIKA-4318) > > > > >> > > > > > >> > Y, that's the main problem. I expect the aggregated javadocs at the > > > > >> > main level `target/reports/apidocs/` > > > > >> > > > > > >> > After Nicholas' PR, I run: `mvn javadoc:aggregate` in main, and I > > > > >> > still get the CheckReturnValue error/failure. > > > > >> > I can avoid that with: `mvn clean package javadoc:aggregate`, but > > > > >> > then, as Tilman notes, there are no reports aggregated at the > > > > >> > project > > > > >> > level. > > > > >> > > > > > >> > What's frustrating is that javadoc:aggregate is cheerfully > > > > >> > reporting > > > > >> > that it is skipping the overall `tika` project: > > > > >> > ``` > > > > >> > --- javadoc:3.11.2:aggregate (default-cli) @ tika --- > > > > >> > [INFO] Skipping > > > > >> > org.apache.maven.plugins:maven-javadoc-plugin:3.11.2:aggregate > > > > >> > report > > > > >> > goal > > > > >> > ``` > > > > >> > I can't figure out why it is skipping the overall project. > > > > >> > > > > > >> > On Wed, May 28, 2025 at 4:06 PM Nicholas DiPiazza > > > > >> > <nicholas.dipia...@gmail.com> wrote: > > > > >> >> > > > > >> >> i tried this > > > > >> >> https://github.com/apache/tika/pull/2222/files > > > > >> >> how do i tell if i fixed the issue? > > > > >> >> > > > > >> >> > > > > >> >> > > > > >> >> On Wed, May 28, 2025 at 2:37 PM Tilman Hausherr > > > > >> >> <thaush...@t-online.de > > > > >> > > > > > >> >> wrote: > > > > >> >> > > > > >> >>> I added this in the pom of grpc: > > > > >> >>> > > > > >> >>> > > > > >> >>> <dependency> > > > > >> >>> <groupId>com.google.errorprone</groupId> > > > > >> >>> <artifactId>error_prone_annotations</artifactId> > > > > >> >>> </dependency> > > > > >> >>> > > > > >> >>> and now it ran, however no javadoc file was generated. (which is > > > > >> >>> also > > > > >> >>> mentioned in TIKA-4318) > > > > >> >>> > > > > >> >>> Tilman > > > > >> >>> > > > > >> >>> > > > > >> >>> On 5/28/2025 9:24 PM, Tilman Hausherr wrote: > > > > >> >>>> On 5/28/2025 9:17 PM, Oleg Tikhonov wrote: > > > > >> >>>>> Honestly I could not understand what is wrong. Can you please > > > > >> explain > > > > >> >>>>> what is not working? > > > > >> >>>> > > > > >> >>>> I think he meant javadoc:aggregate. I tried it myself and it > > > > >> >>>> did fail > > > > >> >>>> in grpc: > > > > >> >>>> > > > > >> >>>> > > > > >> >>>> [INFO] --- compiler:3.14.0:compile (default-compile) @ > > > > >> >>>> tika-grpc --- > > > > >> >>>> [INFO] Recompiling the module because of changed source code. > > > > >> >>>> [INFO] Compiling 29 source files with javac [debug deprecation > > > > >> release > > > > >> >>>> 11] to target\classes > > > > >> >>>> [INFO] > > > > >> >>>> > > > > >> >>> > > > > >> /XXXXXX/tika3/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/ExpiringFetcherStore.java: > > > > >> >>> > > > > >> >>>> Some input files use unchecked or unsafe operations. > > > > >> >>>> [INFO] > > > > >> >>>> > > > > >> >>> > > > > >> /XXXXXX/tika3/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/ExpiringFetcherStore.java: > > > > >> >>> > > > > >> >>>> Recompile with -Xlint:unchecked for details. > > > > >> >>>> [INFO] > > > > >> >>>> ------------------------------------------------------------- > > > > >> >>>> [ERROR] COMPILATION ERROR : > > > > >> >>>> [INFO] > > > > >> >>>> ------------------------------------------------------------- > > > > >> >>>> [ERROR] cannot access > > > > >> com.google.errorprone.annotations.CheckReturnValue > > > > >> >>>> class file for > > > > >> >>>> com.google.errorprone.annotations.CheckReturnValue > > > > >> >>>> not found > > > > >> >>>> [INFO] 1 error > > > > >> >>>> > > > > >> >>>> > > > > >> >>> > > > > >> >>> > > > > >> > > > > >>
