pjfanning commented on code in PR #2186:
URL: https://github.com/apache/tika/pull/2186#discussion_r2038426273
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/xwpf/XWPFStylesShim.java:
##########
@@ -43,9 +43,9 @@ public class XWPFStylesShim {
/**
* Empty singleton to be used when there is no style info
*/
- public static XWPFStylesShim EMPTY_STYLES = new EmptyXWPFStyles();
+ public static final XWPFStylesShim EMPTY_STYLES = new EmptyXWPFStyles();
Review Comment:
this might be dangerous - as the field is public - someone could set the
value to a non empty set of styles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
