[ 
https://issues.apache.org/jira/browse/TIKA-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890216#comment-17890216
 ] 

ASF GitHub Bot commented on TIKA-4309:
--------------------------------------

alexey-pelykh commented on code in PR #1993:
URL: https://github.com/apache/tika/pull/1993#discussion_r1803598853


##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-code-module/src/main/java/org/apache/tika/parser/executable/UniversalExecutableParser.java:
##########
@@ -48,6 +49,9 @@ public class UniversalExecutableParser implements Parser {
     private static final Set<MediaType> SUPPORTED_TYPES =
             Collections.singleton(MediaType.application("x-mach-o-universal"));
 
+    private static final int MAX_ARCHS_COUNT = 1000;

Review Comment:
   There are only 18 known ones and they can't repeat, so I would even say that 
19  (to match the "magic detection") would've been another number we could use.





> ExecutableParser: support MachO
> -------------------------------
>
>                 Key: TIKA-4309
>                 URL: https://issues.apache.org/jira/browse/TIKA-4309
>             Project: Tika
>          Issue Type: New Feature
>            Reporter: Alexey Pelykh
>            Priority: Major
>             Fix For: 3.0.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to