alexey-pelykh commented on PR #1963: URL: https://github.com/apache/tika/pull/1963#issuecomment-2368477122
> Aren't the magic bits at 4096 important for jnilib? Or what is the difference between what we were detecting as x-java-jnilib and mach-O and its variants? Yes and no. There's no guarantee they are at 4096 offset, that's empiric - at least based on what I know as of now. The offset should be read from the file itself - that's why I've asked about dynamic offset. An top of that, we should check that it's a library, not that it's a Mach-O, so technically those checks aren't ideal either. So far we're mimicking the `file` behavior that was also used by this: > This might be useful: https://github.com/gabriel-vasile/mimetype/pull/53/files#diff-db84ad344d2bf91ea9533dbaa5974e81940b053644665471594fb2eedd34e7daR19 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
