tballison commented on code in PR #492:
URL: https://github.com/apache/tika/pull/492#discussion_r1771454305


##########
tika-core/src/main/resources/org/apache/tika/parser/external/tika-external-parsers.xml:
##########
@@ -61,4 +61,57 @@
        <match>\s*([A-Za-z0-9/ \(\)]+\S{1})\s+:\s+([A-Za-z0-9\(\)\[\] 
\:\-\.]+)\s*</match>
      </metadata>
   </parser>
+  <parser>
+     <check>
+       <command>sox --version</command>
+       <error-codes>126,127</error-codes>
+     </check>
+     <command>env FOO=${OUTPUT} sox --info ${INPUT}</command>

Review Comment:
   Why is the `env FOO=${OUTPUT}` command required? Shouldn't `sox --info` 
write to stdout?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to