fpiesche commented on PR #19:
URL: https://github.com/apache/tika-docker/pull/19#issuecomment-1766929188
I'll put some work into some of your concerns. To answer your questions for
now:
1) Dependabot will check for base image updates on a daily basis, *but* will
only open a PR if the latest base image tag has changed. This won't actually
happen with the current setup as the specified tag is not a versionable tag.
What this would do is if e.g. the Dockerfiles switched to using `ubuntu:23.10`
instead of `ubuntu:jammy`, dependabot would open a PR to update this to 24.04
once that image is released, and again 24.10 once that drops, etc. Dependabot
does not check for whether an already-existing tag has had a new image deployed
(as this wouldn't need changes to the Dockerfiles, just a rebuild). Similarly,
the `github-actions` section will ensure that if a new version of any of the
Actions used (e.g. `docker/build-push-action`) is released, Dependabot will
open a PR to update the workflows to use this. CI builds can then run to verify
that the builds still work, after which the PR could just be merged and the
workflows thus kept up to date. This *could* be an up to dail
y task, but updates to GitHub actions are fairly infrequent as well.
2) This is a change I can make - what are the tests you'd want to run? Are
they unit tests, or do they involve bringing up the built image and running
some tests on the build to ensure it's working properly? Either should be
fairly easy to implement.
3) Currently the images are tagged with just the Tika version - however I've
checked and since you already create tags in this GitHub repo with the proper
version numbers, this is just a matter of changing the tag parameter in line 81
of the workflow. I'll change this in a bit...
4) This is correct. Images will be built as `tika-full` and `tika-minimal`
respectively (lines 77/78 of the workflow) and pushed under the `latest` tag
and the version tag to the GitHub container registry and Docker Hub (ie.
they'll be accessible as `ghcr.io/apache/tika-minimal|tika-latest` and
`docker.io/${{secrets.DOCKERHUB_USERNAME}}/tika-minimal|tika-latest`). Tagging
the most recent stable release of an image as `latest` is the de facto standard
with most Docker images; development images usually use `edge` as a generic
"most recent development build" option. The Docker metadata action can [specify
further possible tags](https://github.com/docker/metadata-action#tags-input),
e.g. git commit SHA sums, arbitrary text, build numbers etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
