[
https://issues.apache.org/jira/browse/TIKA-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259279#comment-17259279
]
Kenneth William Krugler commented on TIKA-3263:
-----------------------------------------------
I've meant to comment on this issue of throwing an exception when we hit the
write limit - it always seemed wrong. In the words of Joshua Bloch, exceptions
are for exceptional conditions. If you set a reasonable limit (so you don't
blow memory) then you'll eventually try to parse a file that fails. We should
be communicating that the limit was reached some other way (metadata in
response? haven't thought about it much).
> WriteLimitReachedException is not public
> ----------------------------------------
>
> Key: TIKA-3263
> URL: https://issues.apache.org/jira/browse/TIKA-3263
> Project: Tika
> Issue Type: Bug
> Environment: Windows 10
> Reporter: Peter Kronenberg
> Priority: Major
>
> I got a WriteLimitReachedException because my file was too big. The message
> tells me that the text up the limit is still available. However, it’s tricky
> to get that text and at the same time, respond appropriately to
> SAXExceptions. Originally, my method was catching SAXEXceptions and assume
> there was an error.
> What I really want to do it to be able to catch WriteLimitReachedException,
> but still throw other SAXExceptions, which would indicate that something else
> went wrong. But since WriteLimitReachedException is private, I can’t do that.
>
> Here’s what my code originally looked like:
> !Code1.png!
> But this didn’t work, because if I get a WriteLimitReachedException, it
> doesn’t tell me what data that it got
>
> Given this new knowledge, here’s what I want to do, but I can't, because
> WriteLimitReachedException is private. There's no reason for it to be
> private.
>
> !Code2.png!
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
